This repository has been archived by the owner on Jul 14, 2020. It is now read-only.
Fix major bug in instance address parsing #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`string.strip()` strips any of the passed characters from the string. This commit fixes a bug where any of the characters in ".onion" would be stripped from the end of the onion address. The intention was to remove the string ".onion" if it was included at the end of the provide instance address. This commit uses `.replace() to remove it. Resolves #43.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I introduced a bug in cbda349 which causes instance address parsing to fail if the address ends with any of the letters in ".onion". The correct behavior is to strip the string ".onion" from the end of the address.
Thank you to duritong and Alec Muffett for reporting this.
Resolves #43.