Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when deleting parent with dependent destroy when child uses destroyed_at #68

Merged
merged 1 commit into from
Apr 14, 2016
Merged

Error when deleting parent with dependent destroy when child uses destroyed_at #68

merged 1 commit into from
Apr 14, 2016

Conversation

minimul
Copy link
Contributor

@minimul minimul commented Apr 5, 2016

Fixes #53

@bcardarella
Copy link
Contributor

@minimul can you remove the version bump and can you add a test case for this?

@minimul
Copy link
Contributor Author

minimul commented Apr 5, 2016

Done.

@bcardarella
Copy link
Contributor

Squash/rebase please.

@michaeldupuisjr ^

@minimul
Fix error that occurs when deleting non-destroyed_at parent that has …
d1ad5a7 
…a destroyed_at has_many child marked dependent => destroy
@minimul
Copy link
Contributor Author

minimul commented Apr 5, 2016

Done.

@philiphacks
Copy link

Can we merge this and deploy a new release? Having the same issue...

@michaeldupuisjr michaeldupuisjr merged commit e615bee into DavyJonesLocker:master Apr 14, 2016
@michaeldupuisjr
Copy link
Contributor

Thanks @minimul! Will push a release shortly.

@michaeldupuisjr michaeldupuisjr mentioned this pull request Apr 14, 2016
Merged
@philiphacks
Copy link

@michaeldupuisjr is it also possible to release this on rubygems.org?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@minimul @bcardarella @philiphacks @michaeldupuisjr