Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use RouterService instead of extending Ember Router #255

Closed
buschtoens opened this issue Jul 29, 2020 · 0 comments · Fixed by #270
Closed

Use RouterService instead of extending Ember Router #255

buschtoens opened this issue Jul 29, 2020 · 0 comments · Fixed by #270

Comments

@buschtoens
Copy link
Contributor

Similar to ember-app-scheduler/ember-app-scheduler#772.

Looking at what actually happens in EmberRouterScroll it only seems like routeWillChange and routeDidChange are bound. These events are available on the RouterService as well. To me it looks like we could now easily refactor this addon to avoid the longer inheritance chain.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Major]: refactor: useRouterService instead of Ember Router DockYard/ember-router-scroll
1 participant
@buschtoens