Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving mixin location #11

Closed
bcardarella opened this issue Aug 3, 2016 · 1 comment
Closed

Consider moving mixin location #11

bcardarella opened this issue Aug 3, 2016 · 1 comment

Comments

@bcardarella
Copy link
Member

bcardarella commented Aug 3, 2016

The README states you should use:

import RouterScrollMixin from 'ember-router-scroll';

However the mixin is actually located elsewhere, so you have to do:

import RouterScrollMixin from 'ember-router-scroll/mixins/router-scroll';

which is OK but the line in the README seems better. To achieve this you can move ember-router-scroll/addon/mixins/router-scroll.js to ember-router-scroll/addon/index.js

@briangonzalez
Copy link
Contributor

@bcardarella Agreed.

@bennycwong Mind taking a stab?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants