From 82cf500d907fdc9cdb7727b27decb67594b6d423 Mon Sep 17 00:00:00 2001 From: Brian Gonzalez Date: Tue, 24 Jan 2017 21:07:22 -0800 Subject: [PATCH] [README] A note about ember rfc and core implementation --- README.md | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/README.md b/README.md index bbed0152..907229d4 100644 --- a/README.md +++ b/README.md @@ -10,10 +10,12 @@ ember install ember-router-scroll ``` -## Demo -See [demo](https://dollarshaveclub.github.io/router-scroll-demo/) made by [@Chuabacca](https://github.com/Chuabacca/) +### A small note + +Like all good ember addons, this behavior was considered for core implementation. Good news, people like the idea. For now, the feature will live under the flag `ember-unique-location-history-state` until it's finally released in Ember 2.13. You can follow along for yourself [here](https://github.com/emberjs/ember.js/pull/14011/) and read up on the [RFC](https://github.com/emberjs/rfcs/pull/186#issuecomment-271416805) if you'd like as well. -Relevant repo: [https://github.com/dollarshaveclub/router-scroll-demo](https://github.com/dollarshaveclub/router-scroll-demo) +## Demo +See [demo](https://dollarshaveclub.github.io/router-scroll-demo/) and [repo](https://github.com/dollarshaveclub/router-scroll-demo) made by [Jon Chua](https://github.com/Chuabacca/). ## Real Life Usage @@ -21,13 +23,10 @@ Relevant repo: [https://github.com/dollarshaveclub/router-scroll-demo](https://g ![before-scroll](https://cloud.githubusercontent.com/assets/4430436/17122972/0a1fe454-5295-11e6-937f-f1f5beab9d6b.gif) Notice that the in the full purple page, the user is sent to the **middle** of the page - - ### After ![after-scroll](https://cloud.githubusercontent.com/assets/4430436/17122970/07c1a3a0-5295-11e6-977f-37eb955d95b1.gif) Notice that the in the full purple page, the user is sent to the **top** of the page - ## Why Use it? Ember expects an application to be rendered with nested views. The default behavior is for the scroll position to be preserved on every transition.