From be3be0b76c526343feb012a1de29f6a9beb3f894 Mon Sep 17 00:00:00 2001 From: Scott Newcomer Date: Thu, 24 Dec 2020 12:37:52 -0600 Subject: [PATCH 1/2] CHANGELOG 3.3.5 --- CHANGELOG.md | 6 ++++++ addon/index.js | 7 ------- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index cf6ad9dd..74fc05fd 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,12 @@ - Updating to th v3.0 series was due to removing `scrollWhenPainted` as a config option. Also, we fixed some hidden bugs with scheduling when to scroll to your last y position. +## 3.3.5 +* [#269](https://github.com/DockYard/ember-router-scroll/pull/269) [Enhancement]: improve idle case with improved scrollTo under high loads + +## 3.3.4 +* [#266](https://github.com/DockYard/ember-router-scroll/pull/266) [Deps]: bump app-scheduler 5.1.1 + ## 3.3.0 * [#246](https://github.com/DockYard/ember-router-scroll/pull/246) Add Evented trigger didScroll diff --git a/addon/index.js b/addon/index.js index 6236b0ce..2d07d846 100644 --- a/addon/index.js +++ b/addon/index.js @@ -54,8 +54,6 @@ const CALLBACK = function(transition) { class EmberRouterScroll extends EmberRouter { @inject('router-scroll') service; - idlePool; - @computed get isFastBoot() { const fastboot = getOwner(this).lookup('service:fastboot'); @@ -97,11 +95,6 @@ class EmberRouterScroll extends EmberRouter { * @param {transition|transition[]} transition If before Ember 3.6, this will be an array of transitions, otherwise */ updateScrollPosition(transition) { - if (this.idlePool) { - this.idlePool.destroy(); - this.idlePool = null; - } - const url = get(this, 'currentURL'); const hashElement = url ? document.getElementById(url.split('#').pop()) : null; From f7e5bfa721de186fd9b7bb2430e9bae04c55eaef Mon Sep 17 00:00:00 2001 From: Scott Newcomer Date: Thu, 24 Dec 2020 12:54:31 -0600 Subject: [PATCH 2/2] 3.3.6 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 5d48fe93..cf3230e0 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "ember-router-scroll", - "version": "3.3.5", + "version": "3.3.6", "description": "Scroll to top with preserved browser history scroll position", "keywords": [ "ember-addon",