Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output_columns not used in DataFrameConverter #61

Open
igorbrigadir opened this issue Jan 8, 2023 · 0 comments
Open

output_columns not used in DataFrameConverter #61

igorbrigadir opened this issue Jan 8, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@igorbrigadir
Copy link
Collaborator

igorbrigadir commented Jan 8, 2023

The command line behavior is fine, but when using DataFrameConverter as a library in python code, setting output_columns effectively does nothing,

https://github.com/DocNow/twarc-csv/blob/main/dataframe_converter.py#L530

because that gets applied in

https://github.com/DocNow/twarc-csv/blob/main/csv_writer.py#L70

instead. Internally, DataFrameConverter always works with the full set of columns. Not sure if this is desirable or counter intuitive enough to change, it probably should be outputting the restricted set to be less awkward.

@igorbrigadir igorbrigadir added the bug Something isn't working label Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant