Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix XHR Test #437

Merged
merged 6 commits into from
Sep 11, 2024
Merged

Fix XHR Test #437

merged 6 commits into from
Sep 11, 2024

Conversation

zollqir
Copy link
Collaborator

@zollqir zollqir commented Sep 11, 2024

This test fixes the XHR test that often breaks in CI. This is accomplished by using a local server rather than a remote one we do not control

@zollqir zollqir self-assigned this Sep 11, 2024
@zollqir zollqir added this to the v1.0.0 milestone Sep 11, 2024
Copy link
Member

@Xmader Xmader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xmader Xmader merged commit e72bfd2 into main Sep 11, 2024
35 checks passed
@Xmader Xmader deleted the caleb/fix/xhr-test branch September 11, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants