Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HTML Link Checker #452

Closed
windymilla opened this issue Sep 27, 2024 · 1 comment · Fixed by #747
Closed

Add HTML Link Checker #452

windymilla opened this issue Sep 27, 2024 · 1 comment · Fixed by #747
Labels
core feature Required for basic PPing

Comments

@windymilla
Copy link
Collaborator

Is this still necessary, given the Nu validator?
@windymilla windymilla added the core feature Required for basic PPing label Sep 27, 2024
@tangledhelix
Copy link
Collaborator

I think we do need this, unless we want to change the functionality. Looking over linkcheckrun() in ErrorCheck.pm, it seems to look for image references (in CSS and in HTML) and it checks that they exist on disk. It's also checking the filename case and warning on uppercase (not sure if Nu does that).

It also checks that the link isn't to something external (since PG doesn't want that, IIRC) and will warn on it. I doubt Nu does that.

@windymilla windymilla linked a pull request Feb 10, 2025 that will close this issue
Add HTML Link Checker #747
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core feature Required for basic PPing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add HTML Link Checker windymilla/guiguts-py
2 participants
@tangledhelix @windymilla