Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardize CEDAR template @type field #217

Open
zachll opened this issue May 8, 2024 · 1 comment · May be fixed by #272
Open

standardize CEDAR template @type field #217

zachll opened this issue May 8, 2024 · 1 comment · May be fixed by #272
Assignees
Labels

Comments

@zachll
Copy link
Member

zachll commented May 8, 2024

The CEDAR template for PFBK message templates and causal pathways has been implemented inconsistently, and corrections to these metadata using the CEDAR tool is not straightforward.

Issues that are related to this problem:

  1. Message templates have a faulty IRI for the @type field:

Appears as:
"@type": "http://data.bioontology.org/ontologies/PSDO/classes/http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FPSDO_0000002",

but should be corrected to appear as:
"@type": "http://purl.obolibrary.org/obo/PSDO_0000002",

  1. Causal pathways have been implemented with a top level string "type" instead of the top level "@type" field, and need to be corrected and updated in the PFKB repo

Next steps are to figure out how to update the CEDAR template and regenerate message templates

@pboisver pboisver added the bug label Jun 5, 2024
@pboisver
Copy link
Member

pboisver commented Jun 5, 2024

Update the PFP when this is fixed (in candidate pudding)

@zachll zachll linked a pull request Jul 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants