-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to bevy 0.15 (& 3D support) #165
Comments
I have a few questions about the current design.
I would like my associated PR #166 to cover all these goals, but that's mostly because I'm not productive (or confident) with maintaining more than one git branch to seperately address each individual problem. I'll talk more here after I've actually implemented the MVP for bevy 0.15 though |
As bevy 0.15 is a breaking update I don't think me making some 'minor' (subjective) design changes is too extreme, but I wanted to hear from other people consuming / maintaining this library before I go and stomp on existing design decisions that may be important to others |
My current API prototype: let sprite_edit = (
Sprite,
CosmicEditBuffer::new_foo(),
);
let ui_edit = (
ImageNode::default(), // these two bevy builtin components may be squashed in some cosmic_edit
Button, // specific type like maybe `TextEdit` to mirror `bevy::ui::Text`
CosmicEditBuffer::new_bar(),
);
// idk yet
let 3d_edit = (
Mesh3d::new_plane(), // will work out a way of rendering in 3d
CosmicEditBuffer::new_baz(),
); I think the |
Sorry I don't have much capacity to look into it right now but I am open to any refactorings. 3d support is really great to bring... I think we already tried it in the past: #104 :) |
Yeah I briefly saw that old PR, I'm only interested in plane 3D geometry plus |
Whats the difference between |
There were couple of refactorings so I don't really remember ECS semantics but how I see it: cosmic-text has 2 main abstractions:
It corresponds to CosmicBuffer and CosmicEditor wrappers around cosmic-text abstractions. So, if user wants to create read-only text it makes sense to use buffer, if user wants to have text input - editor. Focused editor/buffer is another thing afaik... imagine user have 2 editors and 2 buffers... focused can be only one editor/buffer so user can type/select text only from one editor/buffer at time. Not sure it helps, not sure it is accurate :) |
Ahh OK that helps a lot thanks |
Yes, the Editor component is only on focussed buffers as I suspected |
Can we get a publish? We can remove TODO.md and the bevy_editor_pls dev dependencies if thats holding it back |
published |
I'm working on a PR
The text was updated successfully, but these errors were encountered: