-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit and make documentation for command LRU
consistent
#815
Comments
@arpitbbhayani Can I take this up ? |
@Srajan007 go for it. assigned. thanks for taking this up. |
@arpitbbhayani Fixed it under this PR, the command LRU didn't exist in Redis. |
Hello @Srajan007, There has been no activity on this issue for the past 5 days. We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work. Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out. Thanks again. |
Unclear to me whether work is still needed on this issue. If so, I'd be willing to work on it. |
@JyotinderSingh @arpitbbhayani May it take this up? I have also raised an issue regarding the same: #1263 |
Assigned |
@JyotinderSingh The current documentation of the LRU command and the actual working differs.
So I should make changes to the documentation following the current working of the command? |
ig it should return the values as Ok won;t be beneficial |
agreed. can i pick up the changes for this? |
So should the LRU command evict the LRU keys and return the evicted keys to the client? In the documentation It doesnt say if the keys are evicted as well or only the information of the LRU keys is returned. |
The documentation of the command
[LRU](https://dicedb.io/commands/lru/)
present in the docs could have become stale. We need your help to ensure that the documentation is complete, correct, and consistent. Completing this issue will give you much-needed exposure to how the command is implemented and the different parameters it accepts. Hence, this is a great way to build a good understanding of the project and its functionality. While still making a significant contribution. Here's what you need to do:Note: The title of the sections should be the exact strings mentioned above, like "Examples", "Return values", etc.
Note: The description of the command in Frontmatter of the command.md file is the first paragraph (introduction) of the command.
Go through the DiceDB/dice repository and explore the command implementation
Please use the documentation of the SET command as the reference point and structure the
documentation of this command in a very similar way, including the following points
127.0.0.1:7379>
and not anything elseIf you find any inconsistencies, please fix the documentation and raise the PR.
The core idea of this exercise is to ensure that the documentation is consistent, correct, and complete.
Make sure you comment on the other issues you created (if any) as a comment on this issue and also any PR (if any) that you created.
Thank you for picking this up and contributing to the DiceDB. It means a ton.
The text was updated successfully, but these errors were encountered: