Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for command GEOSEARCHSTORE #1255

Open
arpitbbhayani opened this issue Nov 7, 2024 · 5 comments
Open

Add support for command GEOSEARCHSTORE #1255

arpitbbhayani opened this issue Nov 7, 2024 · 5 comments
Assignees

Comments

@arpitbbhayani
Copy link
Contributor

Add support for the GEOSEARCHSTORE command in DiceDB similar to the GEOSEARCHSTORE command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

@swarajrb7
Copy link
Contributor

@arpitbbhayani i would like to work on this issue

@tejaswini22199
Copy link

Hi @arpitbbhayani, I would like to take up this issue! Can I work on this task?

@apoorvyadav1111
Copy link
Contributor

Hi @swarajrb7, Assigned. Thanks for contributing to DiceDB.

@helios2003
Copy link
Contributor

Hi @swarajrb7, are you still working on this issue? Otherwise, I would like to take up the issue.

@swarajrb7
Copy link
Contributor

I am working on this issue.
I am waiting for other GEO commands like GEORADIUS and GEORADIUSBYMEMEBER_RO to be merged as many of those functions are used in this command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants