Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add tooltip component #59

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Feature/add tooltip component #59

merged 3 commits into from
Oct 9, 2024

Conversation

RishabhC-137
Copy link
Contributor

@RishabhC-137 RishabhC-137 commented Oct 7, 2024 •
edited
Loading

This pull request resolves several issues mentioned in Issue #35:

  • Styling Fixes: Aligned styles for “Cleanup in:” and “Commands left:”; updated to “Commands left:” and added tooltips.
  • File Cleanup: Removed mockData.json file.
  • Variable Update: Changed “blacklist” to “blocklist” in variable names.

@RishabhC-137 RishabhC-137 reopened this Oct 7, 2024
@RishabhC-137 RishabhC-137 reopened this Oct 7, 2024
@RishabhC-137
Copy link
Contributor Author

@lucifercr07 can you review this pr?

@lucifercr07
Copy link
Contributor

@RishabhC-137 please resolve conflicts.

@RishabhC-137 RishabhC-137 force-pushed the feature/add-tooltip-component branch from 0b0dd96 to a3f49fc Compare October 9, 2024 08:11
@RishabhC-137 RishabhC-137 reopened this Oct 9, 2024
@RishabhC-137
Copy link
Contributor Author

@lucifercr07 can you check

lucifercr07
lucifercr07 requested changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@lucifercr07 lucifercr07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RishabhC-137 can you please add some screenshots for the changes?

next-env.d.ts Outdated Show resolved Hide resolved
@RishabhC-137
Copy link
Contributor Author

RishabhC-137 commented Oct 9, 2024 •
edited
Loading

@lucifercr07 Hi, I added tooltip (i) icons next to both phrases to provide context:

  • "Cleanup in:": "Time remaining for cleanup tasks."
  • "Commands left:": "Number of commands you can still execute."
Recording.2024-10-09.144846.mp4

image
image

@RishabhC-137
Copy link
Contributor Author

@lucifercr07 can you check

@lucifercr07 lucifercr07 merged commit efdc10d into DiceDB:master Oct 9, 2024
1 check passed
@lucifercr07 lucifercr07 mentioned this pull request Oct 9, 2024
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucifercr07 lucifercr07 lucifercr07 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RishabhC-137 @lucifercr07