Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove S03 beamline and system tests which require S03 #631

Open
olliesilvester opened this issue Nov 11, 2024 · 1 comment
Open

Remove S03 beamline and system tests which require S03 #631

olliesilvester opened this issue Nov 11, 2024 · 1 comment
Labels

Comments

@olliesilvester
Copy link
Contributor

olliesilvester commented Nov 11, 2024

As discussed in #183, we think the overhead required to use and maintain the system tests which need S03 is too high, and they haven't been working for a long time. We currently ignore the results of the daily system tests because of this, so we are better off without them

Acceptance Criteria

  • System tests which require S03 are identified and removed. Note that this isn't every test which has @pytest.mark.s03 (but maybe not, see first comment in this issue)
  • The @pytest.mark.s03 marker is changed to a more meaningful name for the remaining system tests
  • All devices annotated with skip=BL == s03 are no longer annotated with skip
  • i03.py has BL = get_beamline_name("i03") instead of s03 and there is no mention of s03 anywhere
@olliesilvester olliesilvester moved this to Candidates for Next Sprint in Hyperion Dec 5, 2024
@rtuck99 rtuck99 moved this from Candidates for Next Sprint to Todo This Sprint in Hyperion Jan 6, 2025
@rtuck99 rtuck99 changed the title Remove system tests which require S03 Remove S03 beamline and system tests which require S03 Jan 10, 2025
@olliesilvester
Copy link
Contributor Author

@rtuck99 I seem to remember there are a few tests which say @pytest.mark.s03 but don't actually have anything to do with s03 - we just marked it with that as the tests don't pass locally for some other reason. So we should be a bit careful to not just remove all the s03 tests without checking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo This Sprint
Development

No branches or pull requests

1 participant