Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

grid_width_microns is required by grid_detection_plan but is not in the experiment params schema #1278

Closed
rtuck99 opened this issue Mar 20, 2024 · 1 comment · Fixed by #1353
Assignees

Comments

@rtuck99
Copy link
Contributor

rtuck99 commented Mar 20, 2024

Currently grid_width_microns is required by grid_detection_plan. It is obtained from the GridScanWithEdgeDetectParams.grid_width_microns via PinCentreThenXrayCentreInternalParameters. However in wait_for_robot_load_then_centre_plan the upstream PinCentreThenXrayCentreInternalParameters is constructed from WaitForRobotLoadThenCentreInternalParameters which doesn't have this attribute, and it is also absent from the corresponding json schema.

This may possibly be mitigated by GDA populating this field anyway, but really we should not be round-tripping parameters via json between unrelated types as this is a source of potential bugs

@DominicOram DominicOram moved this to Backlog in Hyperion Mar 20, 2024
@DominicOram DominicOram moved this from Backlog to Candidates for Next Sprint in Hyperion Mar 24, 2024
@DominicOram DominicOram moved this from Candidates for Next Sprint to Todo This Sprint in Hyperion Mar 25, 2024
@DominicOram
Copy link
Collaborator

If this isn't breaking anything and is just a refactor the idea is to do the bigger parameter refactor instead

@DominicOram DominicOram moved this from Todo This Sprint to Backlog in Hyperion Mar 26, 2024
@DominicOram DominicOram moved this from Backlog to Review in Hyperion May 14, 2024
@DominicOram DominicOram moved this from Review to In Progress in Hyperion May 14, 2024
@DominicOram DominicOram moved this from In Progress to Review in Hyperion May 15, 2024
@DominicOram DominicOram moved this from Review to In Progress in Hyperion May 15, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Hyperion May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants