You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
Currently grid_width_microns is required by grid_detection_plan. It is obtained from the GridScanWithEdgeDetectParams.grid_width_microns via PinCentreThenXrayCentreInternalParameters. However in wait_for_robot_load_then_centre_plan the upstream PinCentreThenXrayCentreInternalParameters is constructed from WaitForRobotLoadThenCentreInternalParameters which doesn't have this attribute, and it is also absent from the corresponding json schema.
This may possibly be mitigated by GDA populating this field anyway, but really we should not be round-tripping parameters via json between unrelated types as this is a source of potential bugs
The text was updated successfully, but these errors were encountered:
Currently
grid_width_microns
is required bygrid_detection_plan
. It is obtained from theGridScanWithEdgeDetectParams.grid_width_microns
viaPinCentreThenXrayCentreInternalParameters
. However inwait_for_robot_load_then_centre_plan
the upstreamPinCentreThenXrayCentreInternalParameters
is constructed fromWaitForRobotLoadThenCentreInternalParameters
which doesn't have this attribute, and it is also absent from the corresponding json schema.This may possibly be mitigated by GDA populating this field anyway, but really we should not be round-tripping parameters via json between unrelated types as this is a source of potential bugs
The text was updated successfully, but these errors were encountered: