Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Robot load: Check PinDetect #1048

Closed
DominicOram opened this issue Dec 15, 2023 · 3 comments · Fixed by #1250
Closed

Robot load: Check PinDetect #1048

DominicOram opened this issue Dec 15, 2023 · 3 comments · Fixed by #1250
Assignees

Comments

@DominicOram
Copy link
Collaborator

DominicOram commented Dec 15, 2023

Following #1234 we can do a robot load. We should now, following it, check that the pin has correctly been loaded.

This can be done by looking at the PinDetected input in the robot load I/O

Acceptance Criteria

  • Hyperion waits for pin detected with a timeout
  • If no pin has been detected we should no longer do the centring and pass back to GDA with a warning exception
@DominicOram DominicOram moved this to Backlog in Hyperion Dec 15, 2023
@stan-dot
Copy link
Contributor

plan link

test link

one other file where file detect is tested

@DominicOram DominicOram moved this from Backlog to Candidates for Next Sprint in Hyperion Mar 7, 2024
@DominicOram
Copy link
Collaborator Author

The way I was thinking of implementing this is that the robot load device only sets the return status to True once the pin has been detected. This should mean the plan doesn't need to worry about details of the check

@DominicOram
Copy link
Collaborator Author

<0.5 days

@DominicOram DominicOram self-assigned this Mar 11, 2024
@DominicOram DominicOram moved this from Candidates for Next Sprint to Review in Hyperion Mar 11, 2024
@DominicOram DominicOram moved this from Review to In Progress in Hyperion Mar 11, 2024
@DominicOram DominicOram moved this from In Progress to Review in Hyperion Mar 11, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in Hyperion Mar 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants