-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataset found #5
Comments
@callumHub Thank you for your insights! I am currently trying to reproduce the model, but am having some difficulties with the model. Is it possible for you to share all the adjustments you have made? That would help me a lot! Best regards |
@reisiiiiiiiiii There was more error messages than what I describe here, but they were all fixable. After finding the data, only a few hours of debugging to get the models to run and give outputs. If you DM me, I can share the 'working' code (and preprocessed data) I have with you then you just have to install packages and run the model, but I find the replication package to be very hard to work with, difficult to understand and to extend for numerous reasons. I've almost finished re-implementing this paper in Pytorch Geometric, direct message me for this. |
@callumHub |
@reisiiiiiiiiii Sorry for the late reply. Email me: [email protected] for the "working code" |
Hello, could you share the "working" code of this model with me? It's also very helpful for me. Thank you very much! |
I pushed the working NYC portion of this replication package. This includes a link to the preprocessed data. https://github.com/callumHub/BikeGraphLSTMReplication |
The paper mentions they get their data from here: https://citibikenyc.com/system-data.
The replication package has scripts which processes this raw data directly in NYC/PrepareData/StationBasicInfo.py.
The weather data is harder to find as the link in the paper did not lead to it.
Instead, google "2015 NYC weather dataset" to find: https://github.com/leokassio/weather-underground-data/blob/master/new-york-2015.csv
This dataset is not hourly but daily, however it can be used in WeatherCondition.py, if you adapt it.
Specifically:
On line 40, 42 and 43 change row[15] to row[2].
On line 33, change row[9] to row[-2],
wind is the same column.
Set the hourly values to the same as the day values, this dataset is daily.
Having access to the actual weather dataset used would still be more ideal, but at least now the replication package is useable.
Also will need to upgrade from tf version 1.x to tf version 2.x. An automated script on the files using tf 1.x and addition of 1 line of code fixes these errors.
The text was updated successfully, but these errors were encountered: