Skip to content
This repository has been archived by the owner on Feb 15, 2022. It is now read-only.

Fixed exchanges.json and reverted some of my suggestions... Double Check! #23

Merged
merged 13 commits into from
Aug 16, 2016

Conversation

ghostnegotiator
Copy link

Double check it before merging... 🐼

@ghostnegotiator
Copy link
Author

Accidentially flipped currency & asset will be fixed by tonight and adding more currencies including USDT.

@ghostnegotiator
Copy link
Author

Fixed... these are all currencies & most errors removed...

This is not tested

@carlos8f carlos8f merged commit 6c113bd into DeviaVir:master Aug 16, 2016
@carlos8f
Copy link
Contributor

thanks for the PR! one thing though, in zenbot, FYI, the trade quote price should always be in the currency and the size is in the asset. I only tested BTC/USDT, but I had to reverse the pair in the id to USDT_BTC for the API calls to work. it seems USDT is a currency in their system, and BTC is the asset (which makes sense).

@ghostnegotiator
Copy link
Author

Hopefly I won't mess up next time, apparently I lost focus on it
eventually. Although its a manual batch job without IDE where errors occur
easily. I definitely need to install an IDE asap.

On Tue, Aug 16, 2016, 23:53 Carlos Rodriguez [email protected]
wrote:

thanks for the PR! one thing though, in zenbot, FYI, the trade quote price
should always be in the currency and the size is in the asset. I only
tested BTC/USDT, but I had to reverse the pair in the id to USDT_BTC for
the API calls to work. it seems USDT is a currency in their system, and
BTC is the asset (which makes sense).


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#23 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AHMwQwTqk_VD_jRXCJpw2j66Ozm3Dg0Kks5qgjFhgaJpZM4JlqfY
.

supersabbath pushed a commit to supersabbath/zenbot that referenced this pull request Oct 2, 2017
Fixed exchanges.json and reverted some of my suggestions... Double Check!
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants