Skip to content
This repository has been archived by the owner on Feb 15, 2022. It is now read-only.

Commit

Permalink
Binance changed API 24 hours to 1 hour (#1027)
Browse files Browse the repository at this point in the history
* Update README

* Update README again

* add generation data to gitignore (#1012)

* binance changed their API strategy from 24 hour windows to 1 hour.
  • Loading branch information
mkuendig authored and DeviaVir committed Jan 2, 2018
1 parent abfd47f commit 860dfc5
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 9 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ sim_result*
trade_result*
*_test
backtesting_*
generation_data_*
models/*.json
models/*.html
*.pyc
Expand Down
14 changes: 7 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
![zenbot logo](https://rawgit.com/carlos8f/zenbot/master/assets/logo.png)
![zenbot logo](https://rawgit.com/deviavir/zenbot/master/assets/logo.png)

> “To follow the path, look to the master, follow the master, walk with the master, see through the master, become the master.”
> – Zen Proverb
Expand Down Expand Up @@ -50,13 +50,13 @@ Zenbot is a command-line cryptocurrency trading bot using Node.js and MongoDB. I
Run in your console,

```
git clone https://github.com/carlos8f/zenbot.git
git clone https://github.com/deviavir/zenbot.git
```

Or, without git,

```
wget https://github.com/carlos8f/zenbot/archive/master.tar.gz
wget https://github.com/deviavir/zenbot/archive/master.tar.gz
tar -xf zenbot-master.tar.gz
mv zenbot-master zenbot
```
Expand Down Expand Up @@ -93,7 +93,7 @@ sudo apt-get install build-essential mongodb -y
curl -sL https://deb.nodesource.com/setup_8.x | sudo -E bash -
sudo apt-get install -y nodejs
git clone https://github.com/carlos8f/zenbot.git
git clone https://github.com/deviavir/zenbot.git
cd zenbot
npm install
Expand Down Expand Up @@ -470,7 +470,7 @@ c.order_adjust_time = 10000

## Reading the console output

![console](https://rawgit.com/carlos8f/zenbot/master/assets/console.png)
![console](https://rawgit.com/deviavir/zenbot/master/assets/console.png)

From left to right:

Expand Down Expand Up @@ -668,7 +668,7 @@ zenbot sell gdax.BTC-USD --pct=10

## Chat with other Zenbot users

[![zenbot logo](https://rawgit.com/carlos8f/zenbot/master/assets/discord.png)](https://discord.gg/ZdAd2gP)
[![zenbot logo](https://rawgit.com/deviavir/zenbot/master/assets/discord.png)](https://discord.gg/ZdAd2gP)

Zenbot has a Discord chat! You can get in [through this invite link](https://discord.gg/ZdAd2gP).

Expand All @@ -680,7 +680,7 @@ P.S., some have asked for how to donate to Zenbot development. I accept donation

`187rmNSkSvehgcKpBunre6a5wA5hQQop6W`

![zenbot logo](https://rawgit.com/carlos8f/zenbot/master/assets/zenbot_square.png)
![zenbot logo](https://rawgit.com/deviavir/zenbot/master/assets/zenbot_square.png)

Thanks!

Expand Down
4 changes: 2 additions & 2 deletions extensions/exchanges/binance/exchange.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,11 @@ module.exports = function container (get, set, clear) {
}
if (args.startTime && !args.endTime) {
// add 12 hours
args.endTime = args.startTime + 43200000
args.endTime = args.startTime + 3600000
}
else if (args.endTime && !args.startTime) {
// subtract 12 hours
args.startTime = args.endTime - 43200000
args.startTime = args.endTime - 3600000
}

var client = publicClient()
Expand Down

0 comments on commit 860dfc5

Please sign in to comment.