Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use consistent IDs in Punishments and PunishmentHisotry #214

Closed
BrainStone opened this issue Jun 12, 2018 · 1 comment
Closed

Use consistent IDs in Punishments and PunishmentHisotry #214

BrainStone opened this issue Jun 12, 2018 · 1 comment
Labels
Feature-Request Implemented

Comments

@BrainStone
Copy link
Contributor

I think it would be better if the table Punishments and PunishmentHisotry shared the same IDs. When using punishments other than kick, they stay in sync anyways. So the auto index of Punishments should just be bumped when a kick is performed to make sure the tables stay in sync. This is especially important when modifying punishments or when using the PunishmentHistory to display the IDs of the bans so users can use it to ask to be pardoned.
@BrainStone BrainStone mentioned this issue Jun 13, 2018
Merged
@BrainStone
Copy link
Contributor Author

Closed by #216

@BrainStone BrainStone mentioned this issue Jun 13, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature-Request Implemented
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BrainStone @DevLeoko