From 88181965023111d1a0b8fec3a11524dc523b127e Mon Sep 17 00:00:00 2001 From: Jonathan Norris Date: Fri, 15 Mar 2024 14:56:45 -0400 Subject: [PATCH] chore: update 'platform' to return 'C#' not including 'Local' / 'Cloud' to match other SDK formats. --- DevCycle.SDK.Server.Cloud.MSTests/DevCycleTest.cs | 2 +- DevCycle.SDK.Server.Common/API/DevCycleBaseClient.cs | 2 +- DevCycle.SDK.Server.Common/Model/Local/PlatformData.cs | 3 +-- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/DevCycle.SDK.Server.Cloud.MSTests/DevCycleTest.cs b/DevCycle.SDK.Server.Cloud.MSTests/DevCycleTest.cs index d6490722..2e264676 100644 --- a/DevCycle.SDK.Server.Cloud.MSTests/DevCycleTest.cs +++ b/DevCycle.SDK.Server.Cloud.MSTests/DevCycleTest.cs @@ -167,7 +167,7 @@ public void User_NullUserId_ThrowsException() private void AssertUserDefaultsCorrect(DevCycleUser user) { - Assert.AreEqual("C# Cloud", user.Platform); + Assert.AreEqual("C#", user.Platform); Assert.AreEqual(DevCycleUser.SdkTypeEnum.Server, user.SdkType); //Assert.AreEqual("1.0.3.0", user.SdkVersion); } diff --git a/DevCycle.SDK.Server.Common/API/DevCycleBaseClient.cs b/DevCycle.SDK.Server.Common/API/DevCycleBaseClient.cs index 0454ae50..8af1d7be 100644 --- a/DevCycle.SDK.Server.Common/API/DevCycleBaseClient.cs +++ b/DevCycle.SDK.Server.Common/API/DevCycleBaseClient.cs @@ -13,7 +13,7 @@ namespace DevCycle.SDK.Server.Common.API { public abstract class DevCycleBaseClient : IDevCycleClient { - public string SdkPlatform => $"C# {Platform()}"; + public string SdkPlatform => $"C#"; private static string CSharpVersion => System.Runtime.InteropServices.RuntimeInformation.FrameworkDescription; private static string SdkVersion => typeof(IDevCycleClient).Assembly.GetName().Version.ToString(); private static DevCycleUser.SdkTypeEnum SdkType => DevCycleUser.SdkTypeEnum.Server; diff --git a/DevCycle.SDK.Server.Common/Model/Local/PlatformData.cs b/DevCycle.SDK.Server.Common/Model/Local/PlatformData.cs index cf466292..040cea02 100644 --- a/DevCycle.SDK.Server.Common/Model/Local/PlatformData.cs +++ b/DevCycle.SDK.Server.Common/Model/Local/PlatformData.cs @@ -4,8 +4,7 @@ namespace DevCycle.SDK.Server.Common.Model.Local { public class PlatformData { - - private const string DefaultPlatform = "C# Local"; + private const string DefaultPlatform = "C#"; private const DevCycleUser.SdkTypeEnum DefaultSdkType = DevCycleUser.SdkTypeEnum.Server; private static readonly string DefaultSdkVersion = typeof(DevCyclePopulatedUser).Assembly.GetName().Version.ToString();