Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: if flake update fails, is PR created? #122

Open
peterbecich opened this issue Jul 14, 2024 · 1 comment
Open

Question: if flake update fails, is PR created? #122

peterbecich opened this issue Jul 14, 2024 · 1 comment

Comments

@peterbecich
Copy link

Thanks for this great GitHub Action. I haven't tested it yet.

What happens if flake update fails? Will the PR still be created?

An example is the hackage-server flake.nix. Right now, nix flake update will fail because the Flake is incompatible with current NixPkgs.

Additionally, building on #91, can additional checks be specified that would prevent the PR from being created?

Assuming the PR is created regardless of flake update success or failure, a broken flake.nix can be caught by other GitHub Action tests on the flake. However, there may be a lot of automated and broken PRs sitting in the list.

@peterbecich
Copy link
Author

I think I've answered my own question; no:

actionsCore.setFailed(`non-zero exit code of ${exitCode} detected`);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant