Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NOT IN precedence issues #128

Closed
matthias-Q opened this issue Mar 29, 2023 · 1 comment
Closed

NOT IN precedence issues #128

matthias-Q opened this issue Mar 29, 2023 · 1 comment

Comments

@matthias-Q
Copy link
Collaborator

As discussed in #126 NOT IN is currently not implemented
@DerekStride DerekStride mentioned this issue Mar 29, 2023
Closed
@DerekStride
Copy link
Owner

Additional context

Implementing NOT IN as mentioned in #126, is causing some errors with precedence. I think the root cause might be from the between expression added in #117. It has a rule seq($._expression, $.keyword_and, $._expression) but the binary_expression node is also defined as seq($._expression, $.keyword_and, $._expression).

Some investigation & work is required to detangle the precedence issues and implement NOT IN.

@matthias-Q matthias-Q mentioned this issue Jun 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DerekStride @matthias-Q