-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Line byproduct #39
Comments
Please see https://github.com/DerKoun/bsnes-hd#widescreen-widescreen-mode
Does this already cover your request? |
I'm having that line with Mode 7 selected in the widescreen menu. I've toyed with it a bit and I saw what it does. The line only disappears when the aspect ratio is set to none but then I have no widescreen. By aspect ratio I mean the option in the emulator. Also I've seen this line present in the second screenshot of this page. |
I'll look into it. But I'll have this at low priority at the moment. |
That's fair. Thanks! |
Me again. If possible, please fix this in the next release. |
The roadmap for the next release is pretty set.
If I can easily reproduce the issue I may be able to resolve it in the following release. |
bsnes-hd beta 10.4 used Settings are default: Screenshots were taken in windowed mode with these settings (the problem does show up in fullscreen as well, don't worry): In any of the games tested the problem never shows up during Mode 7 sequences (when the game actually goes widescreen). Kirby's Dream Land 3 (USA) The line first shows up in the intro animation for GRASS LAND (nothing before that): It then shows up in gameplay but it doesn't go all the way down, not covering the stats segment of the screen (harder to see but it's there): Interestingly the transition animation does cover it: Super Mario RPG - Legend of the Seven Stars (USA) It first shows up in the intro: And the slowly disappears as the screen darkens: Does not show up in the title screen or the save select. Shows up again here: It does not show up while moving about but it is present in combat: It also shows up in: Terranigma, Super Mario World, Super Mario World 2 - Yoshi's Island, Seiken Densetsu 3 (only in the character select and save screen as far as I saw, not in gameplay), Kirby's Dream Course. The only one I found where it didn't show up is Contra III - The Alien Wars but I only played a bit of the first level. Again, it never shows up in Mode 7 sections from what I saw at least. And certain elements, like text boxes or transition animations, do cover it. It feels like a garbage pixel line. If I take any of the screenshots, resize them to the SNES's actual resolution of 256×224, then the line falls outside of this. If I set Widescreen to none in settings then the line is no more: Just a dumb suggestion from an unknowledgeable person, maybe you can make an option where the emulator switches Widescreen to Mode 7 when it detects it running and make it go to none when it's not? If you want more screenshots and games tested please ask! Sorry if those weren't enough. Thank you for taking an interest in this! |
Thank you for the detailed information. I think I found the cause (can't test right know). The background color seems to be painted one pixel to far to the right. If I can verify it this will be in fixed in the next release. |
Fixed in latest release (10.5). Again thanks for your efforts. For those interested: The change is just replacing one |
Thanks a lot man! Appreciate the mention in the changelog. |
You definitively spent more time on this issue than I did. |
Sorry if this is the wrong place for this. I was just wondering if there is any way to get rid of the line that shows up on the right side of the screen:
I've seen this phenomenon with games that go beyond their original resolution.
When the Aspect ratio is set to none the line no longer shows up at the price of widescreen of course. Could it be possible to implement some sort of adaptive aspect ratio that goes to 16:9 only when Mode 7 is detected or something like that?
The text was updated successfully, but these errors were encountered: