Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploading a BOM doesn't update the license of any existing components #3498

Closed
2 tasks done
mykter opened this issue Feb 26, 2024 · 2 comments · Fixed by #3556
Closed
2 tasks done

Uploading a BOM doesn't update the license of any existing components #3498

mykter opened this issue Feb 26, 2024 · 2 comments · Fixed by #3556
Labels
defect Something isn't working p2 Non-critical bugs, and features that help organizations to identify and reduce risk
Milestone

Comments

@mykter
Copy link

mykter commented Feb 26, 2024

Current Behavior

When a BOM is uploaded that has different license information for a component than previously, that information is ignored.

A BOM upload can add license information to a component that has no license, but it can't remove a license or otherwise change one that is already present. Component licenses can be manually modified in the UI - it's just uploading a BOM that doesn't change them.

There is no relevant information in the logs that I can see at TRACE level. Reproduced with postgres and H2.

Steps to Reproduce

  1. Upload a BOM to a project, with a component that has a license.
  2. Change the license in the BOM to a different license (or remove it)
  3. Upload the revised BOM

Expected Behavior

The license in the component reflects what is in the BOM that has been uploaded, regardless of what license information was originally present.

This is what happens when using BOM_PROCESSING_TASK_V2_ENABLED=true on the #3357 branch, so it looks like this has been incidentally fixed by that refactor.

Dependency-Track Version

4.10.1, also present in today's (2024-02-26) snapshot image without V2 processing enabled.

We didn't notice this in 4.9, so think this is a regression from around then, but haven't verified that.

Dependency-Track Distribution

Container Image

Database Server

N/A

Database Server Version

No response

Browser

N/A

Checklist

@mykter mykter added defect Something isn't working in triage labels Feb 26, 2024
@nscuro nscuro added p2 Non-critical bugs, and features that help organizations to identify and reduce risk and removed in triage labels Feb 28, 2024
@aravindparappil46
Copy link
Contributor

Hi!
I have created a PR to address this issue: #3556

@nscuro nscuro added this to the 4.11 milestone Mar 17, 2024
Copy link
Contributor

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
defect Something isn't working p2 Non-critical bugs, and features that help organizations to identify and reduce risk
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants