manager.whenSelected not work

[andrewSvsg]

I use my custom cell class LabelCell in storyboard
This is setup method

func setupTable() {
    manager.startManagingWithDelegate(self)
    manager.registerCellClass(ParamValueCell.self)
    manager.whenSelected(ParamValueCell.self){ postCell, post, indexPath in
      print("Selected \(post) in \(postCell) at \(indexPath)")
    }
  }

I fill cells and they appear in table
but "manager.whenSelected" not work and
print("Selected \(post) in \(postCell) at \(indexPath)") - never called

In debug seems that fail in next place

func reactionsOfType(type: UIReactionType, forView view: Any) -> [UIReaction] {
    ....
    //fail in this place
    reaction.viewClass == unwrappedView.dynamicType.
    ...
}

My cell class
public struct LabelCellModel {  
  let labelValue: Variable<String>
}

public class LabelCell: TableViewCell, ModelTransfer {

  @IBOutlet weak var label: UILabel!

  public func updateWithModel(model: LabelCellModel) {

    model.labelValue.asObservable()
      .takeUntil(rx_reuse)
      .subscribeNext({[weak self] labelText in self?.label.text = labelText })
      .addDisposableTo(disposeBag)
  }
}

[DenTelezhkin]

Do you call registerCellClass method for LabelCell? You have two different types of cells, ParamValueCell and LabelCell.

[andrewSvsg]

Sorry I copied method from another controller
this is actual version

func setupTable() {
    manager.startManagingWithDelegate(self)
    manager.registerCellClass(LabelCell.self)
    manager.whenSelected(LabelCell.self){ postCell, post, indexPath in
      print("Selected \(post) in \(postCell) at \(indexPath)")
}

LabelCell registered with manager

[DenTelezhkin]

What version of DTTableViewManager are you using? In my projects and unit tests whenSelected seems to work fine.

[andrewSvsg]

This records form Podfile.lock

• DTCollectionViewManager (4.5.2):
  • DTModelStorage (~> 2.4.0)
• DTModelStorage (2.4.3):
  • DTModelStorage/Core (= 2.4.3)
• DTModelStorage/Core (2.4.3)
• DTTableViewManager (4.5.3):
  • DTModelStorage (~> 2.4.0)

[DenTelezhkin]

Hmm, interesting. Do you have only one cell, or maybe you have some subclasses also registered?

It would be great if you printed those

//fail in this place
    reaction.viewClass == unwrappedView.dynamicType

What are values for these variables?

[andrewSvsg]

print("reaction.reactionType=\(reaction.reactionType)")
print("type=\(type)")
print("reaction.viewClass=\(reaction.viewClass)")
print("unwrappedView.dynamicType=\(unwrappedView.dynamicType)")
return reaction.reactionType == type && reaction.viewClass == unwrappedView.dynamicType

output:
reaction.reactionType=CellSelection
type=CellSelection
reaction.viewClass=LabelCell
unwrappedView.dynamicType=LabelCell

[andrewSvsg]

I add to return value

            print("reaction.reactionType=\(reaction.reactionType)")
            print("type=\(type)")
            print("reaction.viewClass=\(reaction.viewClass)")
            print("unwrappedView.dynamicType=\(unwrappedView.dynamicType)")

            print("\(reaction.reactionType == type && reaction.viewClass == unwrappedView.dynamicType)")

            return reaction.reactionType == type && reaction.viewClass == unwrappedView.dynamicType

reaction.reactionType=CellSelection
type=CellSelection
reaction.viewClass=LabelCell
unwrappedView.dynamicType=LabelCell
false

[DenTelezhkin]

Wow. So, reaction.viewClass == unwrappedView.dynamicType is failing? That's super weird. The only crazy idea i have right now is maybe you have overloaded comparisons between types?

[andrewSvsg]

Or I have 2 LabelCell classes in project ( and they mixed in runtime

[andrewSvsg]

I can not understand this problem
This works
return reaction.reactionType == type && String(reaction.viewClass) == String(unwrappedView.dynamicType)

but maybe it a source of other issues

[DenTelezhkin]

I think I agree to compare String representations of those variables, however this case needs to be reproduced in our test suite, so we had protection against other issues in the future.

Can i ask you to reproduce this behaviour in unit tests in DTModelStorage?
https://github.com/DenHeadless/DTModelStorage/blob/master/DTModelStorageTests/XCTests/Specs/UIReactionsTestCase.swift

[DenTelezhkin]

Closing due to inactivity, please feel free to reopen if you have any additional information.

[orkenstein]

Hit the same issue. How to reproduce this?

[DenTelezhkin]

I have no idea, never managed to reproduce this behavior. Were you able to reproduce while debugging in Xcode?

If yes, what versions of Xcode, Swift, and DTTableViewManager are you using?

[orkenstein]

Xcode 7.3.1
Swift 2.2
DTCollectionViewManager (4.5.2)
DTModelStorage (2.4.4)
DTTableViewManager (4.5.3)

Just to add some more weirdness. It works under one target, and does not under another. Console output:

Staging:
po reaction.viewClass == unwrappedView.dynamicType
false
po reaction.viewClass
PavemintStaging.ConversationCell
po unwrappedView.dynamicType
PavemintStaging.ConversationCell

Second:
po reaction.viewClass == unwrappedView.dynamicType
true
po reaction.viewClass
PavemintLocal.ConversationCell
po unwrappedView.dynamicType
PavemintLocal.ConversationCell

[DenTelezhkin]

Swift is insane nowadays))) Maybe connected to Debug/Release configurations.

Can you try using previous solution found in this thread?

return reaction.reactionType == type && String(reaction.viewClass) == String(unwrappedView.dynamicType)

[orkenstein]

Yes, this helps.

[orkenstein]

Looks like you've added a commit with this fix. Cool!
Can't wait for a new .pod version.

[DenTelezhkin]

I'm actually making release right now =) I'll update this issue when it will be ready.

[orkenstein]

Cool! Thanks for SWIFT support.

[DenTelezhkin]

Aaand finally all releases are live 🍻

DTModelStorage 2.6.0
DTTableViewManager 4.7.0
DTCollectionViewManager 4.7.0

[orkenstein]

Great! And it works.
Thanks.