Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on import of well ipf, deal with duplication of wells #1083

Closed
luitjansl opened this issue Jun 20, 2024 · 0 comments
Closed

on import of well ipf, deal with duplication of wells #1083

luitjansl opened this issue Jun 20, 2024 · 0 comments
Assignees

Comments

@luitjansl
Copy link
Contributor

sometimes multiple entries with the same ID can be found in an IPF file,

  • possibly with the same x and y coordinates
  • sometimes with the same or different filter top/bottom
  • sometimes with the same timeseries text file path

We distinguish exact spatial (not necessarily temporal) duplication ( of x, y, filter_top, filter_bot, ID, but not necessarily rate )
and inexact duplication where ID and possibly some but not all others of x, y, filter_top, filter_bot.

For exact duplication we want to:
-give a warning in the log file that this happened
-make the ID's unique by appending a suffix (_1, _2,..)
This should upon calling open_projectfile_data (prj)

for inexact duplication:

  • we decide not to log this for now, it is a nice to have.
@github-project-automation github-project-automation bot moved this to 📯 New in iMOD Suite Jun 20, 2024
@luitjansl luitjansl self-assigned this Jun 24, 2024
@luitjansl luitjansl moved this from 📯 New to 🏗 In Progress in iMOD Suite Jun 24, 2024
@luitjansl luitjansl moved this from 🏗 In Progress to 🧐 In Review in iMOD Suite Jun 24, 2024
luitjansl added a commit that referenced this issue Jun 26, 2024
Fixes #1083 

# Description
When importing wells, we now make sure that when the ipf file defines 2
or more wells with the same x, y , filter_top, filter_bottom and id,
then the ID of the second well is appended with "_1", and so on for
successive findings of a well with the same characteristics (_2, _3
etc).

# Checklist

- [X] Links to correct issue
- [ ] Update changelog, if changes affect users
- [X] PR title starts with ``Issue #nr``, e.g. ``Issue #737``
- [X] Unit tests were added
- [ ] **If feature added**: Added/extended example
@luitjansl luitjansl moved this from 🧐 In Review to ✅ Done in iMOD Suite Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants