Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automated detection of country and continent in FiatModel.setup_exposure and FiatModel.setup_vulnerability #430

Open
DirkEilander opened this issue Dec 20, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@DirkEilander
Copy link
Contributor

Kind of request

None

Enhancement Description

Currently, FiatModel.setup_exposure and FiatModel.setup_vulnerability require the user to provide the country and continent. However, based on the model region I believe this information could easily be deducted.

There even seems to be a method in the code ExposureVector.get_continent which should do this, but it is unused as far as I can see. For this method also two new dependencies are introduced pycountry-convert and geopy. Note that pycountry-convert has not seen updates since 2018 and has many several test package as required dependency. I wonder if geopy can also not provide the same information and make pycountry-convert redundant.

Task list

  • update or create new get_continent / get_country method
  • clean up related depenencies
  • use this method in FiatModel.setup_exposure and FiatModel.setup_vulnerability based on model region and remove country and continent arguments

Use case

This would make it much simpler to build a fiat model for any region in an automated way.

Additional Context

No response

@DirkEilander DirkEilander added the enhancement New feature or request label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant