Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop duplicates structures when they are not compound structures #141

Open
2 tasks done
shartgring opened this issue Sep 25, 2024 · 0 comments · May be fixed by #169
Open
2 tasks done

Drop duplicates structures when they are not compound structures #141

shartgring opened this issue Sep 25, 2024 · 0 comments · May be fixed by #169
Assignees
@shartgring
Labels
bug Something isn't working

Comments

@shartgring
Copy link
Collaborator

Version checks

  • I have checked that this issue has not already been reported.
  • I have checked that this bug exists on the latest version.

Reproducible Example

Currently, duplicate structures are allowed and included. These should be dropped unless they are uniquely defined, such as compound structures (multiple weirs, orifices, bridges)

Current behaviour

Non-compound structures are duplicated

Desired behaviour

Non-compound structures should not be duplicated

Additional context

No response
@shartgring shartgring added the bug Something isn't working label Sep 25, 2024
@shartgring shartgring self-assigned this Sep 25, 2024
@shartgring shartgring linked a pull request Oct 2, 2024 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shartgring shartgring

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes related to structures Deltares/hydromt_delft3dfm
1 participant
@shartgring