Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xugrid tests in testbank (contourf) #989

Closed
5 tasks done
veenstrajelmer opened this issue Sep 5, 2024 · 0 comments · Fixed by #992
Closed
5 tasks done

Fix xugrid tests in testbank (contourf) #989

veenstrajelmer opened this issue Sep 5, 2024 · 0 comments · Fixed by #992

Comments

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Sep 5, 2024

Failing testcases:

FAILED tests/test_external_packages.py::test_xugrid_opendataset_ugridplot_contourf - ValueError: triangles are indices into the points and must be in the range 0 <= i < 680 but found value -1
FAILED tests/test_external_packages.py::test_xugrid_opendataset_ugridplot_contour_with_colorbar - ValueError: triangles are indices into the points and must be in the range 0 <= i < 680 but found value -1

Todo:

When running the tests with the branch in Deltares/xugrid#299, there are two other testcases that fail:

  • test_uda_edges_to_faces_interfaces_to_centers: there seems to be something wrong here for “mesh2d_edge_type”, not for the first var >> postprocess_interpolate_edgevar_tofaces.py maybe dcsm and mwra case are useful for testing >> We need to set fill_value=-1 in dfmt.uda_to_faces()
  • test_xarray_decode_default_fillvals: updating the expected value to -1 should do the trick
@veenstrajelmer veenstrajelmer changed the title Fix xugrid tests in testbank Fix xugrid tests in testbank (contourf) Sep 5, 2024
@veenstrajelmer veenstrajelmer linked a pull request Sep 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant