Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify dfmt.copernicusmarine_credentials() function #773

Closed
veenstrajelmer opened this issue Feb 8, 2024 · 0 comments · Fixed by #819
Closed

simplify dfmt.copernicusmarine_credentials() function #773

veenstrajelmer opened this issue Feb 8, 2024 · 0 comments · Fixed by #819

Comments

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Feb 8, 2024

[CMCS-210] subset/get/open_dataset not saving credentials after prompting them (or maybe-login function like this one)

update on 25-3-2024: copernicusmarine>=1.0.7 has skip_if_user_logged_in argument for login() function, so dfmt.copernicusmarine_credentials() can be simplified

Also increase minimal version in pyproject.toml.

update 27-3:
new keyword works, but it does not check the correctness of the credentials:

import os
import copernicusmarine
os.environ["COPERNICUS_MARINE_SERVICE_USERNAME"] = "aa"
os.environ["COPERNICUS_MARINE_SERVICE_PASSWORD"] = "aa"
copernicusmarine.login(skip_if_user_logged_in=True)

Prints: "INFO - 2024-03-27T16:29:02Z - Credentials file stored in C:\Users\veenstra\.copernicusmarine\.copernicusmarine-credentials."

Also update: \site-packages\cachier\core.py:222: DeprecationWarning: ignore_cacheis deprecated and will be removed in a future release, usecachier__ alternative instead.

Update 9-4-2024: since last version 1.1.0 released last Friday, the Copernicus Marine credentials are checked again, so you can test the option --skip-if-user-logged-in in normal conditions now.

@veenstrajelmer veenstrajelmer changed the title phase out copernicusmarine login and reset functions simplify dfmt.copernicusmarine_credentials() function Mar 25, 2024
@veenstrajelmer veenstrajelmer linked a pull request Apr 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant