-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prevent calls to uds.grid
in dfmt
#363
Labels
Comments
This was referenced Jul 11, 2023
Closed
Closed
uds.grid
in dfmt
This was referenced Sep 3, 2024
Closed
Closed
This was referenced Sep 26, 2024
Closed
Closed
This was referenced Jan 14, 2025
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
remove_ghostcells
fails for grid with langeduikers. This raises"TypeError: Can only access grid topology via '.grid' if dataset contains exactly one grid. Dataset contains 2 grids. Use '.grids' instead."
When setting
remove_edges=False
andremove_ghost=False
and usingxugrid>=0.9.0
, the dataset is successfully read. However, more errors will follow when using other dfm_tools functions due to.grid
calls.MWE:
Prevent calls to
.grid
in dfmt code, or escape edges/ghost functions in case of multiple grids. This is at least the case inremove_ghostcells
andremove_unassociated_edges
. But there are more.grid
calls in dfm_tools:dimn_faces = grid.face_dimension
,dimn_nodes = grid.node_dimension
,dimn_edges = grid.edge_dimension
,fill_value = grid.fill_value
,indexer_np = grid.face_node_connectivity
,gridname = uds.grid.name
,uds.grid.to_dataset()[gridname]
,isinstance(uds.grid,xu.Ugrid1d)
,uds.grid.validate_edge_node_connectivity()
,uds.grid.face_node_coordinates
,uds.grid.meshkernel
,uds.grid.crs
,uds.grid.is_geographic
gridname = uds.grid.name
,uds.grid.face_dimension
,uds.grids[0].is_geographic
,uds.grid.bounds
.gridname = ds.grid.name
grid_is_geographic = uds.grid.is_geographic
facedim = uds.grid.face_dimension
The text was updated successfully, but these errors were encountered: