Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for noon and monthly averaged data in dfmt.cmems_nc_to_ini() #1086

Closed
veenstrajelmer opened this issue Jan 28, 2025 · 0 comments · Fixed by #1087
Closed

Support for noon and monthly averaged data in dfmt.cmems_nc_to_ini() #1086

veenstrajelmer opened this issue Jan 28, 2025 · 0 comments · Fixed by #1087

Comments

@veenstrajelmer
Copy link
Collaborator

Just like implemented in #1062, the function dfmt.cmems_nc_to_ini() would benefit from less hard-coding. The function is now specifically suited for daily means stored at midnight. This means when correcting midnight-to-noon in #878, this function will probably fail for most cases. At the moment it also fails for monthly data, since it only does floor/ceil to days and not months. This can be easily resolved by calling _ds_sel_time_outside() implemented in #1062.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

used outside time buffer in cmems_nc_to_ini(), expanded testbank Deltares/dfm_tools
1 participant
@veenstrajelmer