You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ruff is an essential tool to automatically help us maintain this codebase and avoid errors. With the large PRs merged this week we also added a lot of exceptions to be able to merge it. I think we should stop doing that as much as possible. I have already enabled a lot more checks and thereby found and fixed a lot of issues. The remaining issues are mostly related to from x import * being used in the peilbeheerst code. I tried to tackle that as well but stranded halfway, leaving main in a ruff-broken state (it was broken before but we ignored it). So now I challenge @rbruijnshkv and co. to pick up the remaining issues. I care about import * especially because using it prevents a lot of other checks from working well. Also it makes the code harder to read, and hence is widely discouraged.
You can run this to see the currently 53 errors and start ticking them off:
Fixes a part of #120. The goal for this PR is to resolve all 53 open
ruff errors on main, without adding exceptions. Currently the commits in
this PR bring it down to 29. The remaining errors are all of the form
`F821 Undefined name`, where the name is:
- dm_netwerk_path
- gdf_rhws
- model_name
- output_folder
- ribasim_toml
- stored_trc
For various files. Will look with @rbruijnshkv to resolve the rest.
---------
Co-authored-by: rbruijnshkv <[email protected]>
Ruff is an essential tool to automatically help us maintain this codebase and avoid errors. With the large PRs merged this week we also added a lot of exceptions to be able to merge it. I think we should stop doing that as much as possible. I have already enabled a lot more checks and thereby found and fixed a lot of issues. The remaining issues are mostly related to
from x import *
being used in the peilbeheerst code. I tried to tackle that as well but stranded halfway, leaving main in a ruff-broken state (it was broken before but we ignored it). So now I challenge @rbruijnshkv and co. to pick up the remaining issues. I care aboutimport *
especially because using it prevents a lot of other checks from working well. Also it makes the code harder to read, and hence is widely discouraged.You can run this to see the currently 53 errors and start ticking them off:
An example:
If that is fixed, please continue by removing these two lines and fixing the new errors that appear:
Ribasim-NL/ruff.toml
Lines 13 to 14 in 6ea29f2
Happy to assist where I can :)
The text was updated successfully, but these errors were encountered: