Add Mesh2dInsertEdgeFromCoordinates #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasbuykx
approved these changes
Mar 28, 2024
| @@ -1040,6 +1040,25 @@ public interface IMeshKernelApi : IDisposable | |||
| /// <returns>Error code</returns> | |||
| int Mesh2dInsertEdge(int meshKernelId, int startVertexIndex, int endVertexIndex, ref int edgeIndex); | |||
|
|
|||
| /// @brief Insert a new mesh2d edge from 2 coordinates | |||
| /// <param name="meshKernelId"> The id of the mesh state | |||
There was a problem hiding this comment.
Add an explanation that if the coordinate does not (exactly? within some radius?) match a vertex, then a new one is created.
| @@ -156,6 +156,67 @@ public void Mesh2dInsertEdgeThroughApi() | |||
| } | |||
| } | |||
|
|
|||
| [Test] | |||
| public void Mesh2dInsertEdgeFromCoordinatesThroughApi() | |||
There was a problem hiding this comment.
Would be nice to also have a test with inserting an edge with only one coordinate matching an existing vertex, and one with no coordinate matching an existing vertex.
lucacarniato
deleted the
feature/GRIDEDIT-992_add_api_for_inserting_edges
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.