Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on DeltaShell-modified netCDF files #25

Open
kdberends opened this issue May 26, 2022 · 1 comment
Open

Remove dependency on DeltaShell-modified netCDF files #25

kdberends opened this issue May 26, 2022 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@kdberends
Copy link
Member

Currently we need modified netCDF files (using the _sectionbathy and _regionbathy convention). This is undesirable, as it requires the user to be familiar with DeltaShell and DeltaShell coding, and because it adds a dependency on python support in DeltaShell.

Alternatively, see if an external module (e.g. meshkernel) could be incorporated.

@kdberends kdberends added the enhancement New feature or request label May 26, 2022
@kdberends kdberends added this to the FM2PROF 3.0 milestone Jul 31, 2023
@kdberends kdberends self-assigned this Jul 31, 2023
@kdberends
Copy link
Member Author

kdberends commented Jul 31, 2023

31/7/2023 meeting with dev MeshKernel:

  • MeshKernel has python wrappers for functions like 'inpolygon'.
  • Reading/writing netCDF is not done by MeshKernel. Need to implement own functionality.
  • Alternative option is to use Hydrolib-core, which may have all functionality we need to read & write grid files and uses MeshKernel for grid operations.
  • May need to introducte 1 (hydrolib-core) or 2 (hydrolib-core + meshkernel) additional dependencies.
    • MeshKernel API is relatively stable
    • Hydrolib-core API is at version 0.5.

Actions:

  • Refine this issue
  • Implementation end of year

@kdberends kdberends modified the milestones: FM2PROF 3.0, FM2PROF 2.4 Aug 30, 2024
@kdberends kdberends removed their assignment Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant