Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to save sediment discharge #99

Closed
elbeejay opened this issue Sep 4, 2020 · 2 comments · Fixed by #104
Closed

Add ability to save sediment discharge #99

elbeejay opened this issue Sep 4, 2020 · 2 comments · Fixed by #104
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@elbeejay
Copy link
Member

elbeejay commented Sep 4, 2020

We calculate sediment flux, qs, but we provide no options for saving this output.

We should add options to save the figures and grids for this variable.

@elbeejay elbeejay added the good first issue Good for newcomers label Sep 4, 2020
@amoodie
Copy link
Member

amoodie commented Sep 4, 2020

yep, I agree.

I think an overhaul of the netCDF file, in general, is needed.

For example, I think we should save boundary conditions, too. This relates to things we've discussed elsewhere (but I can't find at the moment).

Thanks for bringing this to the front with an issue. I'm going to tackle this soon.

@amoodie amoodie self-assigned this Sep 4, 2020
@amoodie amoodie added the enhancement New feature or request label Sep 4, 2020
@amoodie
Copy link
Member

amoodie commented Sep 4, 2020

Here is an example of the structure we landed on in some old discussion on a slack thread.

output.ext
|  elevation: 
|    | data: t-x-y array
|    | meta: t-value array, keys linking to main meta...
|  velocity: t-x-y array
|    | data: t-x-y array
|    | meta: t-value array, keys linking to main meta...
|  meta: a main metadata set, with some keys linking whatever, maybe containing grid coords?

I'll use this as a starting point for reworking the netcdf file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants