Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does it makes more sense to **always** save the model state in finalize()? (drop the if conditional) #89

Open
amoodie opened this issue Aug 24, 2020 · 0 comments

Comments

@amoodie
Copy link
Member

amoodie commented Aug 24, 2020

Is there any merit to always saving when finalize() is called? (dropping the if conditional)

Yes this would potentially throw off a regular save interval if the run is not due for a save. But, this would ensure that the 'final' state of the model is captured (might be nice in the case of a run with save_dt = 150, dt = 15 and a final time of 295 as an example?). Otherwise a run could just go on and run many iterations, depending on the configuration, that are ultimately not saved.

Alternatively I could see the benefits of outputting a warning to the user telling them that X number of timesteps or amount of time will be run but not saved. Or using the save_dt and dt information to cut a run short and avoid wasted iterations... These concerns are not really pertinent to this PR, just something that occurred to me.

Originally posted by @elbeejay in #78

In reference to first if conditional in finalize()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant