From 775aa106be413f39eb1508169e87d32df7d60661 Mon Sep 17 00:00:00 2001
From: Juliette <663378+jrfnl@users.noreply.github.com>
Date: Fri, 7 Sep 2018 09:53:59 +0200
Subject: [PATCH] Build/PHPCS: use PHPCompatibilityWP and minor ruleset tweak
 (#4)

* Build/PHPCS: use PHPCompatibilityWP

This PR:
* Switches the repo over to use `PHPCompatibilityWP` rather than `PHPCompatibility`.
    As this repo and ruleset appears to be aimed at WordPress projects, using the `PHPCompatibilityWP` ruleset is the better choice to prevent false positives for PHP functions and constants which are back-filled by WP.
* Switches the dependency over to use the repo in the `PHPCompatibility` organisation rather than the one in `wimg`'s personal account.

### References:
* https://github.com/PHPCompatibility/PHPCompatibilityWP
* https://github.com/PHPCompatibility/PHPCompatibility/issues/688
* https://github.com/PHPCompatibility/PHPCompatibility/releases/tag/8.2.0

* PHPCS Ruleset: minor fix

Properties belong to individual sniffs, not to standards. The way the property was set, it was going to be ignored. This minor changes fixes that.
---
 Dekode/ruleset.xml | 7 ++++---
 composer.json      | 2 +-
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/Dekode/ruleset.xml b/Dekode/ruleset.xml
index af00e9a..718cfbf 100644
--- a/Dekode/ruleset.xml
+++ b/Dekode/ruleset.xml
@@ -13,12 +13,13 @@
 	<exclude-pattern>*/node_modules/*</exclude-pattern>
 	
 	<!-- Rules -->
-	<rule ref="WordPress">
+	<rule ref="WordPress"/>
+	<rule ref="WordPress.NamingConventions.ValidHookName">
 		<properties>
-			<property name="additionalWordDelimiters" value="/" />
+			<property name="additionalWordDelimiters" value="/"/>
 		</properties>
 	</rule>
-	<rule ref="PHPCompatibility" />
+	<rule ref="PHPCompatibilityWP" />
 	<rule ref="Generic.Arrays.DisallowLongArraySyntax.Found" />
 	<rule ref="NeutronStandard.StrictTypes.RequireStrictTypes.StrictTypes" />
 	<rule ref="NeutronStandard.Functions.TypeHint.NoReturnType" />
diff --git a/composer.json b/composer.json
index 3b4a7a2..6fb4c91 100644
--- a/composer.json
+++ b/composer.json
@@ -4,7 +4,7 @@
     "type": "phpcodesniffer-standard",
     "require": {
         "wp-coding-standards/wpcs": "^1.0",
-        "wimg/php-compatibility": "^8.2",
+        "phpcompatibility/phpcompatibility-wp": "^1.0",
         "dealerdirect/phpcodesniffer-composer-installer": "^0.4.4",
         "automattic/phpcs-neutron-standard": "^1.5"
     },