Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Multigpu.OFF factory #569

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Fix Multigpu.OFF factory #569

merged 1 commit into from
Dec 13, 2022

Conversation

Louis-Dupont
Copy link
Contributor

@Louis-Dupont Louis-Dupont commented Dec 13, 2022

PB:
hydra resolves "OFF" as a boolean, and we don't process booleans in the typefactory.

@dagshub
Copy link

dagshub bot commented Dec 13, 2022

Copy link
Contributor

@shaydeci shaydeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaydeci shaydeci merged commit 67efa1e into master Dec 13, 2022
@shaydeci shaydeci deleted the hotgix/SG-000-fix_multigpu_OFF branch December 13, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants