Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import AutoLoggerConfig and ConsoleSink separatly #567

Merged
merged 4 commits into from
Dec 13, 2022
Merged

Import AutoLoggerConfig and ConsoleSink separatly #567

merged 4 commits into from
Dec 13, 2022

Conversation

Louis-Dupont
Copy link
Contributor

Motivation:

  • get_logger requires AutoLoggerConfig
  • AutoLoggerConfig and ConsoleSink are imported together in the auto_logging package init
  • ConsoleSink includes some DDP dependencies, which themselves require other imports
    This often creates circular import loops that are hard to fix.

Solution:
Not importing ConsoleSink when importing AutoLoggerConfig

@dagshub
Copy link

dagshub bot commented Dec 13, 2022

Join the discussion on DagsHub!

shaydeci
shaydeci approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@shaydeci shaydeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Louis-Dupont Louis-Dupont merged commit 92de053 into master Dec 13, 2022
@Louis-Dupont Louis-Dupont deleted the hotfix/SG-000-autologging_package_fix branch December 13, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaydeci shaydeci shaydeci approved these changes

@ofrimasad ofrimasad Awaiting requested review from ofrimasad ofrimasad is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Louis-Dupont @shaydeci