Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ConvBNReLU a subclass of ConvBNAct to keep backward compatibililty #554

Merged
merged 5 commits into from
Dec 14, 2022
Merged

Make ConvBNReLU a subclass of ConvBNAct to keep backward compatibililty #554

merged 5 commits into from
Dec 14, 2022

Conversation

BloodAxe
Copy link
Contributor

@BloodAxe BloodAxe commented Dec 8, 2022

No description provided.

@dagshub
Copy link

dagshub bot commented Dec 8, 2022

Join the discussion on DagsHub!

ofrimasad
ofrimasad requested changes Dec 14, 2022
View reviewed changes
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is that code in init.py ?
Can we move it to a separate code file?

@BloodAxe
Copy link
Contributor Author

Why is that code in init.py ?
Good suggestions, thanks. It was added there while ConvBnRelu was a function, but since it's a subclass now it make sense to move to separate file. Done

@BloodAxe BloodAxe requested a review from ofrimasad December 14, 2022 15:25
ofrimasad
ofrimasad approved these changes Dec 14, 2022
View reviewed changes
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofrimasad ofrimasad merged commit b05fd88 into master Dec 14, 2022
@ofrimasad ofrimasad deleted the hotfix/SG-000-make-conv-bn-act-subclass branch December 14, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofrimasad ofrimasad ofrimasad approved these changes

@shaydeci shaydeci Awaiting requested review from shaydeci

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BloodAxe @ofrimasad