Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SG-448- dataset_params and arch_params logging #532

Merged
merged 4 commits into from
Dec 1, 2022
Merged

SG-448- dataset_params and arch_params logging #532

merged 4 commits into from
Dec 1, 2022

Conversation

shaydeci
Copy link
Contributor

@shaydeci shaydeci commented Dec 1, 2022

  • Support for (optional) additional configs to be logged in training's sg_logger.
  • Full recipe config logged when launching train_from_config
  • Small bug fix in base_sg_logger (all configs were added under the same tag=hyper_parameters).

@dagshub
Copy link

dagshub bot commented Dec 1, 2022

Join the discussion on DagsHub!

@shaydeci shaydeci marked this pull request as ready for review December 1, 2022 10:04
@shaydeci shaydeci requested a review from ofrimasad as a code owner December 1, 2022 10:04
ofrimasad
ofrimasad approved these changes Dec 1, 2022
View reviewed changes
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofrimasad ofrimasad merged commit 00c3750 into master Dec 1, 2022
@ofrimasad ofrimasad deleted the feature/SG-448_arch_and_dataset_params_logs branch December 1, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofrimasad ofrimasad ofrimasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shaydeci @ofrimasad