Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] lazy implementation of video predictions #1621

Merged
merged 24 commits into from
Nov 15, 2023
Merged

[Feature] lazy implementation of video predictions #1621

merged 24 commits into from
Nov 15, 2023

Conversation

hakuryuu96
Copy link
Contributor

@hakuryuu96 hakuryuu96 commented Nov 7, 2023 •
edited
Loading

Problem: OOM when predicting detection for a big video
Solution: replace saving each frame in some lists to generator objects and implement lazy prediction pipeline

@BloodAxe BloodAxe marked this pull request as ready for review November 9, 2023 21:58
@BloodAxe
Copy link
Contributor

BloodAxe commented Nov 9, 2023

Minor comments left. LGTM once addressed 💪

BloodAxe
BloodAxe approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@BloodAxe BloodAxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BloodAxe BloodAxe merged commit d925039 into Deci-AI:master Nov 15, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BloodAxe BloodAxe BloodAxe approved these changes

@shaydeci shaydeci Awaiting requested review from shaydeci

@ofrimasad ofrimasad Awaiting requested review from ofrimasad ofrimasad is a code owner

@Louis-Dupont Louis-Dupont Awaiting requested review from Louis-Dupont

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hakuryuu96 @BloodAxe @Louis-Dupont