Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/sg 000 improve breaking change detection with imports #1420

Merged
merged 5 commits into from
Aug 29, 2023
Merged

Hotfix/sg 000 improve breaking change detection with imports #1420

merged 5 commits into from
Aug 29, 2023

Conversation

Louis-Dupont
Copy link
Contributor

@Louis-Dupont Louis-Dupont commented Aug 27, 2023 •
edited
Loading

Issue
Currently the breaking change tests is sensitive to

  • import removal in init
  • Function removal in any module

BUT

  • Removing an import should be OK if it's not a SG dependency (e.g. import warnings)
  • Removing a function from a module should be OK if it is instead imported in the same module (in this case, it is not a breaking change)

This was referenced Aug 24, 2023
Merged
Merged
BloodAxe
BloodAxe approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@BloodAxe BloodAxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BloodAxe BloodAxe merged commit 56a7b99 into master Aug 29, 2023
@BloodAxe BloodAxe deleted the hotfix/SG-000-improve_breaking_change_detection_with_imports branch August 29, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BloodAxe BloodAxe BloodAxe approved these changes

@shaydeci shaydeci Awaiting requested review from shaydeci

@ofrimasad ofrimasad Awaiting requested review from ofrimasad ofrimasad is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Louis-Dupont @BloodAxe