Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update yolox_loss.py #1265

Merged
merged 4 commits into from
Jul 20, 2023
Merged

Update yolox_loss.py #1265

merged 4 commits into from
Jul 20, 2023

Conversation

eran-deci
Copy link
Contributor

No description provided.

BloodAxe
BloodAxe reviewed Jul 14, 2023
View reviewed changes
Copy link
Contributor

@BloodAxe BloodAxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just small typing annotation comment and we can merge this PR

@eran-deci
Copy link
Contributor Author

Thanks for the review @BloodAxe
I addressed the typing annotation issue

@eran-deci eran-deci requested a review from BloodAxe July 16, 2023 10:19
BloodAxe
BloodAxe approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@BloodAxe BloodAxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eran-deci eran-deci merged commit f58fb95 into master Jul 20, 2023
@eran-deci eran-deci deleted the DLE-add_yolox_loss_weights_parameters branch July 20, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BloodAxe BloodAxe BloodAxe approved these changes

@shaydeci shaydeci Awaiting requested review from shaydeci

@ofrimasad ofrimasad Awaiting requested review from ofrimasad ofrimasad is a code owner

@Louis-Dupont Louis-Dupont Awaiting requested review from Louis-Dupont

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eran-deci @BloodAxe