Skip to content

Commit

Permalink
build(@vtmn/svelte): fix canary
Browse files Browse the repository at this point in the history
  • Loading branch information
Tlahey committed Aug 18, 2022
1 parent fec49bd commit 2cc7ea4
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/build-canary.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
id: publish-canary
run: |
npm whoami
lerna publish from-git --canary --preid $PR_NUMBER --no-verify-access --no-private --no-commit-hooks --yes
lerna publish --canary --preid $PR_NUMBER --no-verify-access --no-private --no-commit-hooks --no-changelog --yes
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
Expand All @@ -56,7 +56,7 @@ jobs:
with:
github-token: ${{secrets.GITHUB_TOKEN}}
script: |
const name = 'Publish canary';
const name = 'Publish canary :hatched_chick:';
const { issue: { number: issue_number }, repo: { owner, repo } } = context;
try {
await github.issues.removeLabel({
Expand All @@ -77,7 +77,7 @@ jobs:
script: |
const comment = [
':hatched_chick: **Canary published successfully** !',
'${{ steps.publish-canary.output.result }}'
'Check the workflow https://github.com/Decathlon/vitamin-web/runs/${{ github.run_id }}'
];
return comment.join('\n');
Expand Down
1 change: 0 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,6 @@ When you open your Pull Request provide as much information as possible.
- For an issue, describe what you are fixing with your pull request and how you had found the defect.
- If you are proposing an enhancement, describe what you are adding to the code (new function, performance enhancement, documentation update, changing an existing function, ...).


#### Publish canary version

On your newest pull request, it is possible to publish a canary version in order to test it on your project before the final publish.
Expand Down

0 comments on commit 2cc7ea4

Please sign in to comment.