Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

love.audio.stop() without arguments causes an error #7

Open
Davidobot opened this issue Sep 17, 2020 · 3 comments
Open

love.audio.stop() without arguments causes an error #7

Davidobot opened this issue Sep 17, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@Davidobot
Copy link
Owner

Davidobot commented Sep 17, 2020

love.audio.stop() seems to error when called without arguments.

EDIT: running the function on its own doesn't do anything. Need to pin-point the issue further.

@Davidobot Davidobot added the bug Something isn't working label Sep 17, 2020
@Yolwoocle
Copy link

Hello. I just encountered this issue. I was able to pinpoint the source of my game's crashes to this function call. You can look at a version of my project with this issue, in game.lua, line 595 in Game:on_menu. https://github.com/Yolwoocle/bugscraper/tree/765f52a21382f89833d99e14e1694926d1c5b12d

@FormularSumo
Copy link

Calling love.audio.stop() with multiple sources or with no parameters, meaning it applies to all sources, causes love.js to crash if one of the sources that it's being applied to is currently playing. Similarly using love.audio.pause in the same way doesn't cause a crash, but doesn't do anything at all. The issue comes from this emscripten bug I believe emscripten-core/emscripten#16633 which has been patched since, but I don't think love.js is using a recent enough version of emscripten to have receiced the fix as the issue stills persists in the most recent version of love.js.

I noticed that according to #56 love.js might be stuck on emscripten 2.0.3 due to later versions missing the getMemory function. Perhaps if it can't be updated anytime soon, the pull request that fixed this issue could be included in the version of emscripten that love.js does currently use?

@kristinalustig
Copy link

I'm experiencing this crash as well. If anyone else is losing their minds searching for a solution, a valid workaround is to call nameOfAudioFile:stop() for each audio file that could possibly be playing. Pretty janky but at least it eliminates the crash!

@qixils qixils mentioned this issue Sep 15, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants