Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Few issues #32

Closed
rvalitov opened this issue Oct 23, 2018 · 3 comments
Closed

Few issues #32

rvalitov opened this issue Oct 23, 2018 · 3 comments
Assignees
@DavidePastore
Labels
enhancement
Milestone
0.3.0

Comments

@rvalitov
Copy link
Contributor

Hi!
Thank you for your work, but current version lacks the following functionality:

  • use HTTPS to contact ipinfo.io instead of HTTP
  • set timeout for the operation

If you could improve that, then it could be a great project!
@DavidePastore DavidePastore self-assigned this Oct 28, 2018
@DavidePastore DavidePastore added this to the 0.3.0 milestone Oct 28, 2018
@DavidePastore DavidePastore mentioned this issue Oct 28, 2018
Merged
@rvalitov
Copy link
Contributor Author

rvalitov commented Nov 1, 2018

Thank you for a fast update! Waiting for the timeouts! I guess that's not complicated, you can use the timeout options for curl.

@DavidePastore DavidePastore mentioned this issue Nov 1, 2018
Merged
@DavidePastore
Copy link
Owner

Fixed with #33 and #36.

@DavidePastore
Copy link
Owner

Issues fixed and released in the v.0.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DavidePastore DavidePastore

Labels
enhancement
Projects
None yet
Milestone
0.3.0
Development

No branches or pull requests
2 participants
@DavidePastore @rvalitov